Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show logs on failed tests #1307

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jul 16, 2024

This PR allows pytest to show captured log messages for failed tests by removing --show-capture=no from the pytest options.

Regtests passed with no errors: https://github.com/spacetelescope/RegressionTests/actions/runs/9959656242

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@braingram braingram requested a review from a team as a code owner July 16, 2024 15:19
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.37%. Comparing base (459e8e3) to head (ddf3c07).
Report is 252 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files         117      117           
  Lines        8086     8086           
=======================================
  Hits         6418     6418           
  Misses       1668     1668           
Flag Coverage Δ *Carryforward flag
nightly 62.86% <ø> (ø) Carriedforward from 459e8e3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@schlafly schlafly merged commit 7f4bc19 into spacetelescope:main Jul 17, 2024
30 of 33 checks passed
@braingram braingram deleted the show_capture branch July 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants