-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary global variable and unit tests. #1314
Remove unnecessary global variable and unit tests. #1314
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
- Coverage 79.37% 79.28% -0.10%
==========================================
Files 117 117
Lines 8086 8065 -21
==========================================
- Hits 6418 6394 -24
- Misses 1668 1671 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6ae25f6
to
344a1c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #1306
This PR eliminates the global variable
ALIGN_TO_ABS_REFCAT
fromTweakRegStep
and the two unit tests that used it. SinceTweakRegStep
is always used for absolute astrometry, there is no need to have that global variable with fixed value.Regression Tests
All tests are passing:
Checklist
CHANGES.rst
under the corresponding subsection