delete unreachable code

[braingram]

As noted c49de36#r144502886

#1241 included unreachable code.

This is being flagged by sonarqube and preventing regression tests.

This PR deletes the unreachable code. I can also confirm that I intended to delete the code for #1241 but missed it in the swatch of changes.

Regression tests running:
https://github.com/spacetelescope/RegressionTests/actions/runs/10043812086
passed quality gate, tests running.

Fixes: #1321

Checklist

• added entry in CHANGES.rst under the corresponding subsection
• updated relevant tests
• updated relevant documentation
• updated relevant milestone(s)
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

[zacharyburnett]

whoops sorry, jumped the gun and made a duplicate PR 😅

[schlafly]

Feel free to merge when you're ready; clearly orphaned code.

Out of curiosity, the orphaned code looks to play the buffering game; is that a feature that we still have elsewhere? Thanks!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.12%. Comparing base (c49de36) to head (5916052).
Report is 187 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
- Coverage   79.12%   79.12%   -0.01%     
==========================================
  Files         117      117              
  Lines        7824     7823       -1     
==========================================
- Hits         6191     6190       -1     
  Misses       1633     1633              

Flag	Coverage Δ		*Carryforward flag
nightly	63.39% <ø> (ø)		Carriedforward from c49de36

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[braingram]

Feel free to merge when you're ready; clearly orphaned code.

Out of curiosity, the orphaned code looks to play the buffering game; is that a feature that we still have elsewhere? Thanks!

Thanks! The orphaned code is all pertaining to the get_sections API of ModelContainer. This didn't quite work as intended (it didn't prevent loading all models into memory and in the worst case would read each model fresh from disk for every ~1 MB of input data).

The ModelLibrary does not have get_sections and instead the code now computes the median of the already in-memory models. Outlier detection will continue to be a bottleneck for large associations until the median algorithm can be reworked. I'm happy to provide more details if they're helpful.

[braingram]

Regression tests show only the expected minor differences from #1241