Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin stcal for development #1326

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

ddavis-stsci
Copy link
Collaborator

@ddavis-stsci ddavis-stsci commented Jul 23, 2024

Resolves RCAL-nnnn

Closes #

This PR pins stcal so that the new AIP changes will not break new installs of romancal. Once these AIP changes are implemented in romancal the upper pin can be removed.

Checklist

@ddavis-stsci ddavis-stsci added this to the 24Q4_B15 milestone Jul 23, 2024
@ddavis-stsci ddavis-stsci self-assigned this Jul 23, 2024
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner July 23, 2024 11:44
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.12%. Comparing base (a8d1007) to head (7fdd711).
Report is 185 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1326   +/-   ##
=======================================
  Coverage   79.12%   79.12%           
=======================================
  Files         117      117           
  Lines        7823     7823           
=======================================
  Hits         6190     6190           
  Misses       1633     1633           
Flag Coverage Δ *Carryforward flag
nightly 63.39% <ø> (ø) Carriedforward from 3f1565a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ddavis-stsci ddavis-stsci merged commit 492c618 into spacetelescope:main Jul 23, 2024
30 checks passed
@braingram braingram mentioned this pull request Jul 30, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants