Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump actions/labeler from 4 to 5 (#1231)" #1332

Closed
wants to merge 1 commit into from

Conversation

braingram
Copy link
Collaborator

This reverts commit 12b756e.

labeler v5 requires a different file format. See spacetelescope/jwst#8117 for an example of migrating the configuration.

This PR reverts the version bump to v5 so we can continue to use the labeler CI (with version 4) until the configuration file can be updated.

Note that it is not expected that the labeler will run successfully with this PR since it is run as in a pull_request_target job which uses the configuration from the target (main) branch.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@zacharyburnett
Copy link
Collaborator

Note that it is not expected that the labeler will run successfully with this PR since it is run as in a pull_request_target job which uses the configuration from the target (main) branch.

oof, so that's why the tests passed 😅 I'll work on the file format, sorry about that!

@braingram braingram enabled auto-merge July 26, 2024 14:52
@zacharyburnett zacharyburnett mentioned this pull request Jul 26, 2024
6 tasks
@zacharyburnett
Copy link
Collaborator

updated at #1333

@braingram braingram disabled auto-merge July 26, 2024 14:57
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (73e8b77) to head (4516ba9).
Report is 185 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1332   +/-   ##
=======================================
  Coverage   79.05%   79.05%           
=======================================
  Files         117      117           
  Lines        7846     7846           
=======================================
  Hits         6203     6203           
  Misses       1643     1643           
Flag Coverage Δ *Carryforward flag
nightly 63.36% <ø> (ø) Carriedforward from 73e8b77

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram
Copy link
Collaborator Author

Closing in favor of #1333

@braingram braingram closed this Jul 26, 2024
@zacharyburnett zacharyburnett deleted the revert_1231 branch July 26, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants