Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only load patch table when needed #1367

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Aug 15, 2024

This PR modifies the mosaic pipeline and patch match submodule to only load the patch table when required (instead of at import).

Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/10404395165

Closes #1366

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.48%. Comparing base (482ef5c) to head (1993203).
Report is 237 commits behind head on main.

Files with missing lines Patch % Lines
romancal/pipeline/mosaic_pipeline.py 0.00% 4 Missing ⚠️
romancal/patch_match/patch_match.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
- Coverage   78.61%   78.48%   -0.13%     
==========================================
  Files         117      117              
  Lines        7856     7861       +5     
==========================================
- Hits         6176     6170       -6     
- Misses       1680     1691      +11     
Flag Coverage Δ *Carryforward flag
nightly 62.24% <ø> (ø) Carriedforward from 482ef5c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@braingram braingram marked this pull request as ready for review August 15, 2024 14:20
@braingram braingram requested a review from a team as a code owner August 15, 2024 14:20
@braingram braingram requested a review from schlafly August 15, 2024 14:20
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brett, that looks good to me!

@braingram braingram enabled auto-merge August 26, 2024 17:41
@braingram braingram merged commit 26d0393 into spacetelescope:main Aug 26, 2024
26 checks passed
@braingram braingram deleted the patch_table_load branch August 26, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only load patch table when needed
2 participants