-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a default suffix to ELP #1378
Conversation
Marking it as Draft because it needs a test and until it's confirmed this is what SDP needs. |
This comment was marked as resolved.
This comment was marked as resolved.
With this fix in place I get
2024-08-22 15:40:49,833 - stpipe.TweakRegStep - INFO - Saved model in r0000101001001001001_01101_0002_WFI10_cal.asdf
|
Regtests running at: https://github.com/spacetelescope/RegressionTests/actions/runs/10514634684 EDIT: restarted these after the addition of the new regtest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local tests in the comments
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1378 +/- ##
==========================================
+ Coverage 78.58% 78.61% +0.03%
==========================================
Files 117 117
Lines 7862 7856 -6
==========================================
- Hits 6178 6176 -2
+ Misses 1684 1680 -4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Co-authored-by: Brett Graham <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
assert model.meta.cal_step.flat_field == "COMPLETE" | ||
assert model.meta.cal_step.photom == "COMPLETE" | ||
assert model.meta.cal_step.source_detection == "COMPLETE" | ||
assert model.meta.cal_step.tweakreg == "INCOMPLETE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
There's an open issue already for why this isn't SKIPPED
: spacetelescope/roman_datamodels#343
Resolves RCAL-898
Closes #1379
This PR addresses an issue in OPS where files generated from the ELP do not have the expected suffix.
With this change passing
--sufix=
to thestrun
command generates output with the specified suffix. If no suffix is passed, the default suffix iscal
.Checklist
CHANGES.rst
under the corresponding subsection