Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for ols ramp fitting #1398

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Sep 6, 2024

This PR drops support for ols ramp fitting (the algorithm used by jwst). It will allow jwst to make breaking changes to the algorithm (like that is spacetelescope/stcal#275) without concern for roman usage.

The ramp fit step and docs are updated with one minor docs fix where previously use_ramp_jump_detection was listed as an option only for ols even though it's an option for ols_cas22.

I believe #630 refers to optional output for ols (and not anything for ols_cas22) so this PR should fix #630 and closes https://jira.stsci.edu/browse/RCAL-437.

Regression tests all passed https://github.com/spacetelescope/RegressionTests/actions/runs/10745176751

Checklist

  • for a public change, added a towncrier news fragment in changes/

    echo "changed something" > changes/<PR#>.<changetype>.rst

    • changes/<PR#>.general.rst: infrastructure or miscellaneous change
    • changes/<PR#>.docs.rst
    • changes/<PR#>.stpipe.rst
    • changes/<PR#>.associations.rst
    • changes/<PR#>.scripts.rst
    • changes/<PR#>.mosaic_pipeline.rst
    • changes/<PR#>.patch_match.rst

    steps

    • changes/<PR#>.dq_init.rst
    • changes/<PR#>.saturation.rst
    • changes/<PR#>.refpix.rst
    • changes/<PR#>.linearity.rst
    • changes/<PR#>.dark_current.rst
    • changes/<PR#>.jump_detection.rst
    • changes/<PR#>.ramp_fitting.rst
    • changes/<PR#>.assign_wcs.rst
    • changes/<PR#>.flatfield.rst
    • changes/<PR#>.photom.rst
    • changes/<PR#>.flux.rst
    • changes/<PR#>.source_detection.rst
    • changes/<PR#>.tweakreg.rst
    • changes/<PR#>.skymatch.rst
    • changes/<PR#>.outlier_detection.rst
    • changes/<PR#>.resample.rst
    • changes/<PR#>.source_catalog.rst
  • updated relevant tests

  • updated relevant documentation

  • updated relevant milestone(s)

  • added relevant label(s)

  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@github-actions github-actions bot added documentation Improvements or additions to documentation ramp_fitting testing labels Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.52%. Comparing base (908f0f9) to head (afa628b).
Report is 282 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
+ Coverage   78.46%   78.52%   +0.06%     
==========================================
  Files         117      117              
  Lines        7866     7833      -33     
==========================================
- Hits         6172     6151      -21     
+ Misses       1694     1682      -12     
Flag Coverage Δ *Carryforward flag
nightly 62.24% <ø> (ø) Carriedforward from 908f0f9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review September 6, 2024 22:28
@braingram braingram requested a review from a team as a code owner September 6, 2024 22:28
@braingram braingram requested a review from nden September 9, 2024 21:09
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram merged commit 5b214b4 into spacetelescope:main Sep 12, 2024
30 checks passed
@braingram braingram deleted the drop_ols branch September 12, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ramp_fitting testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Tests for Ramp Optional Output
2 participants