Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Pre-commit update #1462

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

Closes #1141

This PR fixes the issues caught by pre commit in its automatic update, all of these are minor.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Docs failure is unrelated see: #1463

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (f23b480) to head (97f7ef8).
Report is 191 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1462   +/-   ##
=======================================
  Coverage   78.07%   78.07%           
=======================================
  Files         119      119           
  Lines        7695     7695           
=======================================
  Hits         6008     6008           
  Misses       1687     1687           
Flag Coverage Δ *Carryforward flag
nightly 62.03% <ø> (ø) Carriedforward from f23b480

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pre-commit-ci bot and others added 2 commits October 17, 2024 12:37
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.5.0...v5.0.0)
- [github.com/asottile/pyupgrade: v3.15.1 → v3.18.0](asottile/pyupgrade@v3.15.1...v3.18.0)
- [github.com/astral-sh/ruff-pre-commit: v0.2.2 → v0.6.9](astral-sh/ruff-pre-commit@v0.2.2...v0.6.9)
- [github.com/psf/black: 24.2.0 → 24.10.0](psf/black@24.2.0...24.10.0)
- [github.com/PyCQA/bandit: 1.7.7 → 1.7.10](PyCQA/bandit@1.7.7...1.7.10)
@WilliamJamieson WilliamJamieson force-pushed the bugfix/pre_commit_update branch from 097cfc2 to 97f7ef8 Compare October 17, 2024 16:37
@WilliamJamieson WilliamJamieson merged commit 39b1404 into spacetelescope:main Oct 18, 2024
31 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/pre_commit_update branch October 18, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants