Switch skymatch to use stcal

[WilliamJamieson]

The shared skymatch code by romancal and jwst has been moved into stcal by spacetelescope/stcal#310. This PR switches romancal's skymatch to use this code.

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

news fragment change types...

• changes/<PR#>.general.rst: infrastructure or miscellaneous change
• changes/<PR#>.docs.rst
• changes/<PR#>.stpipe.rst
• changes/<PR#>.associations.rst
• changes/<PR#>.scripts.rst
• changes/<PR#>.mosaic_pipeline.rst
• changes/<PR#>.patch_match.rst

steps

• changes/<PR#>.dq_init.rst
• changes/<PR#>.saturation.rst
• changes/<PR#>.refpix.rst
• changes/<PR#>.linearity.rst
• changes/<PR#>.dark_current.rst
• changes/<PR#>.jump_detection.rst
• changes/<PR#>.ramp_fitting.rst
• changes/<PR#>.assign_wcs.rst
• changes/<PR#>.flatfield.rst
• changes/<PR#>.photom.rst
• changes/<PR#>.flux.rst
• changes/<PR#>.source_detection.rst
• changes/<PR#>.tweakreg.rst
• changes/<PR#>.skymatch.rst
• changes/<PR#>.outlier_detection.rst
• changes/<PR#>.resample.rst
• changes/<PR#>.source_catalog.rst

[codecov]

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.02%. Comparing base (c8ba216) to head (e91b332).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
romancal/skymatch/skymatch_step.py	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
+ Coverage   78.17%   80.02%   +1.85%     
==========================================
  Files         116      112       -4     
  Lines        7683     6844     -839     
==========================================
- Hits         6006     5477     -529     
+ Misses       1677     1367     -310     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mcara]

Would it be possible to run regression tests on this PR and spacetelescope/stcal#310 branch?

[schlafly]

This looks great to me if regtests pass!

[nden]

Is there a regression test run with this PR and stcal/main?

[WilliamJamieson]

The regression tests pass: https://github.com/spacetelescope/RegressionTests/actions/runs/13397227205

Looks like the CI failures are due to webbpsf changes.

[WilliamJamieson]

Docs appear to be failing due to

WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://webbpsf.readthedocs.io/en/latest/objects.inv' not readable due to ValueError: unknown or unsupported inventory version: ValueError('invalid inventory header: ')

This looks also webbpsf related.

[WilliamJamieson]

Regression tests pass: https://github.com/spacetelescope/RegressionTests/actions/runs/13503542166/job/37727792607

[schlafly]

LGTM, thanks!