Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crds keywords #1510

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Conversation

schlafly
Copy link
Collaborator

We missed updating the CRDS version & context keywords as part of the B16 L1/L2 metadata refactoring. This PR updates their names.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.25%. Comparing base (9031ae1) to head (642096e).
Report is 140 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1510   +/-   ##
=======================================
  Coverage   76.25%   76.25%           
=======================================
  Files         115      115           
  Lines        7639     7639           
=======================================
  Hits         5825     5825           
  Misses       1814     1814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator Author

I did a regression test run here:
https://github.com/spacetelescope/RegressionTests/actions/runs/11803097124
The failures are all ~expected changes in crds.sw_version and crds.context_used. But okifying won't do the right thing because the L1s also have these fields and so the new files that are being made have both the new and old keywords. We need to use a new set of L1s that I've prepared in /grp/roman/eschlafly/romanisim/20241112/regtestl1s to fix this.

Copy link
Collaborator

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mairanteodoro
Copy link
Collaborator

mairanteodoro commented Nov 13, 2024

We need to use a new set of L1s that I've prepared in /grp/roman/eschlafly/romanisim/20241112/regtestl1s to fix this.

I ran all the regtests locally on the new L1 files and they all passed, except for one that was expected and will be fixed after okifying it.

@schlafly schlafly marked this pull request as ready for review November 13, 2024 15:51
@schlafly schlafly requested a review from a team as a code owner November 13, 2024 15:51
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mairanteodoro mairanteodoro merged commit efe4f32 into spacetelescope:main Nov 13, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants