-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crds keywords #1510
Fix crds keywords #1510
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
=======================================
Coverage 76.25% 76.25%
=======================================
Files 115 115
Lines 7639 7639
=======================================
Hits 5825 5825
Misses 1814 1814 ☔ View full report in Codecov by Sentry. |
d692fae
to
23406de
Compare
I did a regression test run here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I ran all the regtests locally on the new L1 files and they all passed, except for one that was expected and will be fixed after okifying it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
We missed updating the CRDS version & context keywords as part of the B16 L1/L2 metadata refactoring. This PR updates their names.