Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute undistorted coordinates #1612

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Compute undistorted coordinates #1612

merged 5 commits into from
Feb 12, 2025

Conversation

nden
Copy link
Collaborator

@nden nden commented Feb 11, 2025

Resolves RCAL-997

Closes #1599

This PR addresses a request by SSC to provide a way to compute undistorted pixels.
It's a temporary fix. Eventually a coordinate frame should be added to the WCS pipeline and the transforms should be
split in the distortion file.

The function is private on purpose as it will change in the future and will be finally removed.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

@nden nden requested a review from a team as a code owner February 11, 2025 15:43
@nden nden requested a review from schlafly February 11, 2025 15:43
@nden nden requested a review from tddesjardins February 11, 2025 15:43
@nden nden requested a review from a team as a code owner February 11, 2025 15:52
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (6534f9d) to head (bb39ce0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
romancal/assign_wcs/__init__.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1612      +/-   ##
==========================================
- Coverage   78.14%   78.11%   -0.04%     
==========================================
  Files         116      116              
  Lines        7629     7635       +6     
==========================================
+ Hits         5962     5964       +2     
- Misses       1667     1671       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nadia, looks reasonable to me. Shall I go ahead and merge?

@nden nden merged commit 7e1723c into spacetelescope:main Feb 12, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function to return distortion free coordinates
2 participants