allow MosaicModel

[zacharyburnett]

Resolves RCAL-958

also allows MosaicModel when creating previews

roman_static_preview preview /grp/roman/ddavis/roman/level3_products/r00001_p_v01001001001_r274dp63x31y80_f158_coadd_i2d.asdf test.png 400 400

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

news fragment change types...

• changes/<PR#>.general.rst: infrastructure or miscellaneous change
• changes/<PR#>.docs.rst
• changes/<PR#>.stpipe.rst
• changes/<PR#>.associations.rst
• changes/<PR#>.scripts.rst
• changes/<PR#>.mosaic_pipeline.rst
• changes/<PR#>.patch_match.rst

steps

• changes/<PR#>.dq_init.rst
• changes/<PR#>.saturation.rst
• changes/<PR#>.refpix.rst
• changes/<PR#>.linearity.rst
• changes/<PR#>.dark_current.rst
• changes/<PR#>.jump_detection.rst
• changes/<PR#>.ramp_fitting.rst
• changes/<PR#>.assign_wcs.rst
• changes/<PR#>.flatfield.rst
• changes/<PR#>.photom.rst
• changes/<PR#>.flux.rst
• changes/<PR#>.source_detection.rst
• changes/<PR#>.tweakreg.rst
• changes/<PR#>.skymatch.rst
• changes/<PR#>.outlier_detection.rst
• changes/<PR#>.resample.rst
• changes/<PR#>.source_catalog.rst

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (826a972) to head (8d80848).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
romancal/scripts/static_preview.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1613   +/-   ##
=======================================
  Coverage   78.16%   78.16%           
=======================================
  Files         116      116           
  Lines        7643     7643           
=======================================
  Hits         5974     5974           
  Misses       1669     1669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ddavis-stsci]

LGTM

[schlafly]

This looks fine, but we likely need to adjust the automatic scaling. I think the reason the image looks so bad is that most of the image is empty, and the automatic percentiles are deciding that the range needs to be very minute around 0 in order to show that empty data. We should probably set the auto-scaling to use only valid pixels (err > 0).