Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-1016 move skycell wcs reading into resample #1642

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Feb 25, 2025

Resolves https://jira.stsci.edu/browse/RCAL-1016

Closes #1615
Closes #1643

Regtests (with skycell wcs disabled for outlier detection) show 1 failure due to a resample regtest using an association with a skycell target. With this PR that association uses the skycell and produces the expected difference:
https://github.com/spacetelescope/RegressionTests/actions/runs/13523271813/attempts/2

Regtests (with skycell wcs enabled for outlier detection):
https://github.com/spacetelescope/RegressionTests/actions/runs/13523271813
show an additional difference for test_mos_skycell_pipeline when comparing the result and truth files.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

@braingram braingram changed the title move skycell wcs reading into resample RCAL-1016 move skycell wcs reading into resample Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 64.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (7484c38) to head (67a586d).

Files with missing lines Patch % Lines
romancal/pipeline/mosaic_pipeline.py 5.55% 17 Missing ⚠️
romancal/patch_match/patch_match.py 84.61% 8 Missing ⚠️
romancal/resample/resample.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
+ Coverage   80.02%   80.12%   +0.10%     
==========================================
  Files         112      111       -1     
  Lines        6844     6748      -96     
==========================================
- Hits         5477     5407      -70     
+ Misses       1367     1341      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant