Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pytest-astropy sphinx extension with pytest-doctestplus #259

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

eslavich
Copy link
Collaborator

Description

This PR attempts to resolve the doc build failure due to changes in sphinx_astropy 1.5.0.

Checklist

  • Tests

  • Documentation

  • Change log

  • Milestone

  • Label(s)

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #259 (83b424e) into main (a70e49a) will decrease coverage by 11.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #259       +/-   ##
===========================================
- Coverage   58.16%   46.38%   -11.79%     
===========================================
  Files          36       35        -1     
  Lines         753      746        -7     
===========================================
- Hits          438      346       -92     
- Misses        315      400       +85     
Flag Coverage Δ
nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
romancal/flatfield/flat_field.py 26.47% <0.00%> (-64.71%) ⬇️
romancal/flatfield/flat_field_step.py 28.00% <0.00%> (-56.00%) ⬇️
romancal/regtest/regtestdata.py 27.04% <0.00%> (-27.56%) ⬇️
romancal/stpipe/core.py 80.00% <0.00%> (-13.34%) ⬇️
setup.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70e49a...83b424e. Read the comment docs.

@eslavich eslavich requested review from ddavis-stsci and dmggh July 22, 2021 16:27
Copy link
Contributor

@dmggh dmggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@eslavich eslavich merged commit b2628d1 into spacetelescope:main Jul 22, 2021
@eslavich eslavich deleted the eslavich-drop-doctest-ext branch July 22, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants