new param for saturation, continute to not flag adjacent pixels for now #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshanahan1
force-pushed
the
adj_sat_pixels
branch
from
f793680 to
8d0c71f
Compare
Codecov Report
@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 68.81% 68.81%
=======================================
Files 39 39
Lines 1023 1023
=======================================
Hits 704 704
Misses 319 319
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
|
Needs a rebase |
cshanahan1
force-pushed
the
adj_sat_pixels
branch
from
8d0c71f to
833537b
Compare
nden
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new parameter to control the flagging of pixels adjacent to saturated pixels was added to stcal [#83]. This PR just maintains NOT flagging adjacent pixels - the tests need to be modified for this and it's needed for JWST, so it can be added later.