Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-327 Allow Nan's in linearity ref file remove romanad from setup. #484

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

ddavis-stsci
Copy link
Collaborator

GitHub issue, Closes #472

Resolves RCAL-327

Description

This PR addresses allows NaN's in the linearity reference file to be updated for processing.
I also took the opportunity to remove romanad from the setup.cfg file.

Checklist

  • Tests

  • [N/A] Documentation

  • Change log

  • Milestone

  • Label(s)

Tests with INS's input files:

strun romancal.step.LinearityStep test_in_Apr29.asdf --override_linearity='roman_linearity_WFI01.asdf'
2022-04-29 09:54:05,345 - CRDS - ERROR - Error determining best reference for 'pars-linearitystep' = Unknown reference type 'pars-linearitystep'
2022-04-29 09:54:05,346 - stpipe.LinearityStep - INFO - LinearityStep instance created.
2022-04-29 09:54:05,384 - stpipe.LinearityStep - INFO - Step LinearityStep running with args ('test_in_Apr29.asdf',).
2022-04-29 09:54:05,386 - stpipe.LinearityStep - INFO - Step LinearityStep parameters are: {'pre_hooks': [], 'post_hooks': [], 'output_file': None, 'output_dir': None, 'output_ext': '.asdf', 'output_use_model': False, 'output_use_index': True, 'save_results': True, 'skip': False, 'suffix': None, 'search_output_file': True, 'input_dir': ''}
2022-04-29 09:54:05,483 - stpipe.LinearityStep - INFO - Using Linearity reference file /Users/ddavis/src/Roman/develop/linearity/Apr08_2022/roman_linearity_WFI01.asdf
2022-04-29 09:54:11,432 - stpipe.LinearityStep - INFO - Saved model in test_in_Apr29_linearitystep.asdf
2022-04-29 09:54:11,432 - stpipe.LinearityStep - INFO - Step LinearityStep done

The regression tests will fail until CRDS is updated with updated reference files.

@ddavis-stsci ddavis-stsci added this to the Build 0.6 milestone Apr 29, 2022
@ddavis-stsci ddavis-stsci self-assigned this Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #484 (1027d8f) into main (5532653) will decrease coverage by 0.60%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
- Coverage   78.29%   77.69%   -0.61%     
==========================================
  Files          39       39              
  Lines        1023     1031       +8     
==========================================
  Hits          801      801              
- Misses        222      230       +8     
Flag Coverage Δ *Carryforward flag
nightly 78.29% <100.00%> (ø) Carriedforward from ce06d60

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
romancal/linearity/linearity_step.py 68.29% <57.14%> (-16.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5532653...1027d8f. Read the comment docs.

@ddavis-stsci ddavis-stsci requested review from PaulHuwe and dmggh April 29, 2022 15:34
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ddavis-stsci ddavis-stsci merged commit c0cf0f5 into spacetelescope:main Apr 29, 2022
@ddavis-stsci ddavis-stsci deleted the rcal-327_dsd branch April 29, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot open linearity file containing NaN values
2 participants