Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-332 populate meta.ref_file #492

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Conversation

cshanahan1
Copy link
Collaborator

@cshanahan1 cshanahan1 commented May 10, 2022

GitHub issue, Closes #

Resolves RCAL-332

Description

This PR addresses ...

Checklist

  • Tests

  • Documentation

  • Change log

  • Milestone

  • Label(s)

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #492 (bf8e9fd) into main (2ef49c9) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

❗ Current head bf8e9fd differs from pull request most recent head 55653ee. Consider uploading reports for the commit 55653ee to get more accurate results

@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   79.45%   79.36%   -0.09%     
==========================================
  Files          41       41              
  Lines        1212     1231      +19     
==========================================
+ Hits          963      977      +14     
- Misses        249      254       +5     
Flag Coverage Δ *Carryforward flag
nightly 79.45% <100.00%> (ø) Carriedforward from 2ef49c9
unit 47.13% <25.00%> (-0.08%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
romancal/stpipe/core.py 85.71% <50.00%> (-9.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef49c9...55653ee. Read the comment docs.

@cshanahan1 cshanahan1 force-pushed the ref_file branch 2 times, most recently from 6bfdbd2 to 8c0d858 Compare May 23, 2022 13:19
@nden nden requested a review from PaulHuwe June 1, 2022 18:24
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a test?

@nden
Copy link
Collaborator

nden commented Jun 7, 2022

When I process a file with this PR, the ref_file structure is not completely populated, i.e. none of the reference file names is there, only the CRDS info.

cal.meta.ref_file
Out[4]: {'crds': {'context_used': 'roman_0033.pmap', 'sw_version': '11.16.1'}}

I think this may be an issue with the schema.

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to figure out why ref_file is not populated. It's best to start with reviewing the schema

@cshanahan1 cshanahan1 force-pushed the ref_file branch 2 times, most recently from bbfaff2 to 807c2a5 Compare July 28, 2022 15:09
@cshanahan1 cshanahan1 changed the title RCAL-332populate meta.ref_file RCAL-332 populate meta.ref_file Jul 28, 2022
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - two minor comments

@cshanahan1 cshanahan1 force-pushed the ref_file branch 3 times, most recently from 7a3fd81 to d6036b4 Compare July 29, 2022 20:11
@nden
Copy link
Collaborator

nden commented Aug 1, 2022

I verified this populates the ref_file structure. I'm seeing a validation error raised from calibration_software_version on the cal file. I don't think it's related to this PR.

@nden nden merged commit 0e76724 into spacetelescope:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants