-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-332 populate meta.ref_file #492
Conversation
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
==========================================
- Coverage 79.45% 79.36% -0.09%
==========================================
Files 41 41
Lines 1212 1231 +19
==========================================
+ Hits 963 977 +14
- Misses 249 254 +5
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
6bfdbd2
to
8c0d858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have a test?
When I process a file with this PR, the
I think this may be an issue with the schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to figure out why ref_file is not populated. It's best to start with reviewing the schema
bbfaff2
to
807c2a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - two minor comments
7a3fd81
to
d6036b4
Compare
I verified this populates the ref_file structure. I'm seeing a validation error raised from |
GitHub issue, Closes #
Resolves RCAL-332
Description
This PR addresses ...
Checklist
Tests
Documentation
Change log
Milestone
Label(s)