Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distortion transform to assign_wcs #510

Merged
merged 7 commits into from
Jun 3, 2022

Conversation

WilliamJamieson
Copy link
Collaborator

GitHub issue, Closes #462

Resolves RCAL-319

Description

Adds distortion transform to assign_wcs

Checklist

  • Tests

  • Documentation

  • Change log

  • Milestone

  • Label(s)

@WilliamJamieson WilliamJamieson force-pushed the feature/distortion branch 2 times, most recently from 89f1f85 to f8f707c Compare May 23, 2022 18:43
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #510 (4d1804e) into main (96db80f) will increase coverage by 0.54%.
The diff coverage is 93.10%.

@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   82.33%   82.87%   +0.54%     
==========================================
  Files          39       39              
  Lines        1036     1057      +21     
==========================================
+ Hits          853      876      +23     
+ Misses        183      181       -2     
Flag Coverage Δ *Carryforward flag
nightly 82.33% <81.81%> (ø) Carriedforward from 96db80f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
romancal/assign_wcs/assign_wcs_step.py 91.80% <93.10%> (+9.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96db80f...4d1804e. Read the comment docs.

@WilliamJamieson WilliamJamieson force-pushed the feature/distortion branch 4 times, most recently from cb7e194 to 1e13906 Compare May 25, 2022 18:28
@WilliamJamieson WilliamJamieson marked this pull request as ready for review May 25, 2022 18:33
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nden nden merged commit 2ab74c6 into spacetelescope:main Jun 3, 2022
@WilliamJamieson WilliamJamieson deleted the feature/distortion branch June 3, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update assign_wcs to include distortion
2 participants