Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecation warnings ahead of Pytest 8.0 #597

Merged

Conversation

zacharyburnett
Copy link
Collaborator

resolves SCSB-53

This PR addresses the Pytest deprecations introduced in 7.2 ahead of the 8.0 release.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@zacharyburnett zacharyburnett self-assigned this Nov 1, 2022
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 79.42% // Head: 79.42% // No change to project coverage 👍

Coverage data is based on head (4ddb138) compared to base (67d9e1a).
Patch has no changes to coverable lines.

❗ Current head 4ddb138 differs from pull request most recent head b93fa52. Consider uploading reports for the commit b93fa52 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   79.42%   79.42%           
=======================================
  Files          41       41           
  Lines        1244     1244           
=======================================
  Hits          988      988           
  Misses        256      256           
Flag Coverage Δ
nightly 79.42% <0.00%> (ø)
unit 46.31% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett force-pushed the fix_pytest_deprecations branch from 5af7536 to 28ddff4 Compare December 6, 2022 15:23
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Dec 6, 2022
@zacharyburnett zacharyburnett force-pushed the fix_pytest_deprecations branch from 10b7c8a to 5468dbe Compare December 12, 2022 14:59
@zacharyburnett zacharyburnett marked this pull request as ready for review December 21, 2022 17:32
@zacharyburnett zacharyburnett force-pushed the fix_pytest_deprecations branch from 5468dbe to 6b27f09 Compare December 21, 2022 17:32
@zacharyburnett zacharyburnett force-pushed the fix_pytest_deprecations branch from 6b27f09 to b93fa52 Compare December 21, 2022 18:07
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure what this function does. if it works 👍 to merging

@zacharyburnett zacharyburnett merged commit 5833bd7 into spacetelescope:main Dec 21, 2022
@zacharyburnett zacharyburnett deleted the fix_pytest_deprecations branch December 21, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants