Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change duplicate numpy120 to numpy122 #604

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Dec 1, 2022

This PR fixes a small issue with numpy122

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 81.50% // Head: 81.50% // No change to project coverage 👍

Coverage data is based on head (6f8ebae) compared to base (e36b2a5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files          39       39           
  Lines        1173     1173           
=======================================
  Hits          956      956           
  Misses        217      217           
Flag Coverage Δ *Carryforward flag
nightly 81.83% <ø> (ø) Carriedforward from e36b2a5
unit 46.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharyburnett zacharyburnett merged commit a4f77b4 into spacetelescope:main Dec 5, 2022
@zacharyburnett zacharyburnett deleted the ci_numpy_fix branch December 5, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants