Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] fix CI on PRs from forks #617

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Dec 21, 2022

This PR addresses the issue where PRs from forks cannot run because they don't have access to the DD_API_KEY organizational secret.

Hotfix for #615

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 79.42% // Head: 79.42% // No change to project coverage 👍

Coverage data is based on head (d04adee) compared to base (4ddb138).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   79.42%   79.42%           
=======================================
  Files          41       41           
  Lines        1244     1244           
=======================================
  Hits          988      988           
  Misses        256      256           
Flag Coverage Δ *Carryforward flag
nightly 79.42% <ø> (ø) Carriedforward from 67d9e1a
unit 46.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett marked this pull request as ready for review December 21, 2022 18:03
@zacharyburnett zacharyburnett changed the title fix CI on PRs from forks due to access to organizational secrets [hotfix] fix CI on PRs from forks due to access to organizational secrets Dec 21, 2022
@zacharyburnett zacharyburnett changed the title [hotfix] fix CI on PRs from forks due to access to organizational secrets [hotfix] fix CI on PRs from forks Dec 21, 2022
@zacharyburnett zacharyburnett merged commit ed62a13 into spacetelescope:main Dec 21, 2022
@zacharyburnett zacharyburnett deleted the hotfix/ci_on_fork_prs branch December 21, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant