Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-486: Update Maker Utlity Imports #654

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Mar 1, 2023

Resolves RCAL-486

Closes #

This PR addresses changes in the location of datamodel maker utilities in RDM.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.08 ⚠️

Comparison is base (4c50af4) 57.08% compared to head (55354a5) 57.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   57.08%   57.00%   -0.08%     
==========================================
  Files          76       76              
  Lines        4045     4045              
==========================================
- Hits         2309     2306       -3     
- Misses       1736     1739       +3     
Flag Coverage Δ *Carryforward flag
nightly 56.94% <ø> (-0.07%) ⬇️ Carriedforward from 4c50af4
unit 46.94% <50.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
romancal/dark_current/dark_current_step.py 88.52% <50.00%> (-1.64%) ⬇️
romancal/dq_init/dq_init_step.py 78.57% <50.00%> (-1.79%) ⬇️
romancal/ramp_fitting/ramp_fit_step.py 96.25% <50.00%> (-1.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PaulHuwe PaulHuwe marked this pull request as ready for review March 2, 2023 15:31
Copy link
Collaborator

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHuwe PaulHuwe merged commit 96f919b into spacetelescope:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants