Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import tomli as tomllib for docs builds before Python 3.11 #657

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Mar 9, 2023

tomli is implemented read-only as tomllib in Python 3.11

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@zacharyburnett zacharyburnett self-assigned this Mar 9, 2023
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.83 ⚠️

Comparison is base (96fb108) 63.67% compared to head (f4fa6b0) 62.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   63.67%   62.84%   -0.83%     
==========================================
  Files          78       78              
  Lines        4113     4113              
==========================================
- Hits         2619     2585      -34     
- Misses       1494     1528      +34     
Flag Coverage Δ *Carryforward flag
nightly 56.66% <ø> (-6.96%) ⬇️ Carriedforward from 3a43351

*This pull request uses carry forward flags. Click here to find out more.

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed dependencies Pull requests that update a dependency file labels Mar 9, 2023
@zacharyburnett zacharyburnett changed the title make tomli hard dependency for docs import tomli as tomllib for docs builds before Python 3.11 Mar 9, 2023
@zacharyburnett zacharyburnett merged commit 0c9077a into spacetelescope:main Mar 29, 2023
@zacharyburnett zacharyburnett deleted the tomli_docs branch March 29, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no-changelog-entry-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants