Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple outlier detection step. #689

Merged
merged 12 commits into from
May 12, 2023

Conversation

PaulHuwe
Copy link
Collaborator

@PaulHuwe PaulHuwe commented Apr 27, 2023

Resolves RCAL-550

Closes #

This PR adds a simple outlier detection step. There is no algorithm used here, just the framework work.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 47.05% and project coverage change: -0.13 ⚠️

Comparison is base (c15db2e) 77.70% compared to head (ccf111f) 77.58%.

❗ Current head ccf111f differs from pull request most recent head d540d1a. Consider uploading reports for the commit d540d1a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   77.70%   77.58%   -0.13%     
==========================================
  Files          80       82       +2     
  Lines        4284     4301      +17     
==========================================
+ Hits         3329     3337       +8     
- Misses        955      964       +9     
Flag Coverage Δ *Carryforward flag
nightly 64.48% <ø> (ø) Carriedforward from 1b2a97d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
romancal/lib/suffix.py 94.28% <ø> (ø)
romancal/stpipe/integration.py 100.00% <ø> (ø)
...mancal/outlier_detection/outlier_detection_step.py 35.71% <35.71%> (ø)
romancal/outlier_detection/__init__.py 100.00% <100.00%> (ø)
romancal/step.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added documentation Improvements or additions to documentation pipeline labels May 1, 2023
@PaulHuwe PaulHuwe marked this pull request as ready for review May 3, 2023 17:15
@PaulHuwe PaulHuwe requested a review from a team as a code owner May 3, 2023 17:15
Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHuwe PaulHuwe force-pushed the RCAL-550_L3Outlier branch from 8aef221 to d540d1a Compare May 12, 2023 19:51
@PaulHuwe PaulHuwe merged commit ef415d8 into spacetelescope:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pipeline stpipe testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants