Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-567 Update unit tests to add tmpdir for test files #702

Merged
merged 4 commits into from
May 24, 2023

Conversation

ddavis-stsci
Copy link
Collaborator

Resolves RCAL-567

Closes #

This PR updates unit tests to add tmpdir for test files.
Unit tests
pytest /Users/ddavis/src/Roman/romancal/romancal/associations/tests/
=================================================================== test session starts ===================================================================
platform darwin -- Python 3.11.0, pytest-7.3.1, pluggy-1.0.0
rootdir: /Users/ddavis/src/Roman/romancal
configfile: pyproject.toml
...
============================================================== 55 passed, 1 skipped in 0.98s
ls *.json
ls: *.json: No such file or directory

pytest /Users/ddavis/src/Roman/romancal/romancal/tweakreg/tests/
=================================================================== test session starts ===================================================================
platform darwin -- Python 3.11.0, pytest-7.3.1, pluggy-1.0.0
rootdir: /Users/ddavis/src/Roman/romancal
configfile: pyproject.toml
plugins: remotedata-0.4.0, hypothesis-6.75.1, asdf-2.15.0, mock-3.10.0, filter-subpackage-0.1.2, astropy-header-0.2.2, doctestplus-0.12.1, astropy-0.10.0, cov-4.0.0, ci-watson-0.6.1, openfiles-0.5.0, arraydiff-0.5.0
collected 94 items

../../../romancal/romancal/tweakreg/tests/test_astrometric_utils.py ....................................... [ 41%]
../../../romancal/romancal/tweakreg/tests/test_tweakreg.py ....................................................... [100%]
...
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================================== 94 passed, 6 warnings in 73.33s (0:01:13) ========================================================
(rcal_python311) bash>ls ref_cat.escv
ls: ref_cat.escv: No such file or directory

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • [N/A] updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 30.00% and project coverage change: -0.20 ⚠️

Comparison is base (b02786e) 77.61% compared to head (5ad9de2) 77.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   77.61%   77.41%   -0.20%     
==========================================
  Files          82       82              
  Lines        4315     4322       +7     
==========================================
- Hits         3349     3346       -3     
- Misses        966      976      +10     
Flag Coverage Δ *Carryforward flag
nightly 64.53% <ø> (ø) Carriedforward from b02786e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
romancal/associations/main.py 81.76% <30.00%> (-5.74%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ddavis-stsci ddavis-stsci marked this pull request as ready for review May 23, 2023 18:22
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner May 23, 2023 18:22
@ddavis-stsci ddavis-stsci merged commit 486169d into spacetelescope:main May 24, 2023
@ddavis-stsci ddavis-stsci deleted the rcal-567_dsd branch May 24, 2023 11:40
mairanteodoro pushed a commit to mairanteodoro/romancal that referenced this pull request May 30, 2023
…pe#702)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants