Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CI #706

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented May 30, 2023

This PR addresses 2 issues:

  1. I have begun to notice 143 errors with our CI. This is due to over use of action runner resources, which I believe is related to using too much memory. This memory issue is simply because xdist will be running multiple tests simultaneously which eats up too much memory under certain conditions.
  2. The titles of the CI runs in GitHub are not very distinguishable. This PR updates them to make them more clear.

This PR is similar to spacetelescope/roman_datamodels#187.

Note the "required" CI in the branch protections will likely need to be updated after this PR is merged.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ea68910) 77.44% compared to head (0e8a1d8) 77.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   77.44%   77.44%           
=======================================
  Files          82       82           
  Lines        4322     4322           
=======================================
  Hits         3347     3347           
  Misses        975      975           
Flag Coverage Δ *Carryforward flag
nightly 64.56% <ø> (ø) Carriedforward from ea68910

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll work on applying this in other repos as well

@WilliamJamieson WilliamJamieson marked this pull request as ready for review May 31, 2023 22:02
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner May 31, 2023 22:02
@zacharyburnett zacharyburnett merged commit 0c3897e into spacetelescope:main Jun 1, 2023
@WilliamJamieson WilliamJamieson deleted the ci/clean_up branch June 1, 2023 17:59
@WilliamJamieson WilliamJamieson mentioned this pull request Jun 1, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants