add sdpdeps toxenv
#708
Merged
add sdpdeps toxenv
#708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
requested changes
Jun 1, 2023
There was a problem hiding this comment.
This seams fine, lets wait for #709 to merge, and then rebase. That way we can trigger the CI in question within the PR
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
=======================================
Coverage 75.51% 75.51%
=======================================
Files 90 90
Lines 5452 5452
=======================================
Hits 4117 4117
Misses 1335 1335
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
WilliamJamieson
approved these changes
Jun 16, 2023
mairanteodoro
pushed a commit
to mairanteodoro/romancal
that referenced
this pull request
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
sdpdepstoxenv, like in the JWST pipeline, that installsrequirements-sdp.txtChecklist
added entry inCHANGES.rstunder the corresponding subsectionupdated relevant milestone(s)