Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-604 update ramp fitting unit test for stcal 1.4.0 #725

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

ddavis-stsci
Copy link
Collaborator

@ddavis-stsci ddavis-stsci commented Jun 28, 2023

Resolves RCAL-604

Closes #

This PR updates the ramp fitting unit tests for changes in stcal needed by JWST (JP-3242)

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
pytest --pdb ~/src/Roman/romancal/romancal/ramp_fitting/tests/test_ramp_fit.py
=============================================================== test session starts ================================================================
platform darwin -- Python 3.11.0, pytest-7.3.1, pluggy-1.0.0
rootdir: /Users/ddavis/src/Roman/romancal
configfile: pyproject.toml
plugins: remotedata-0.4.0, env-0.8.1, asdf-2.15.0, mock-3.10.0, filter-subpackage-0.1.2, astropy-header-0.2.2, hypothesis-6.75.3, doctestplus-0.12.1, astropy-0.10.0, cov-4.0.0, ci-watson-0.6.1, openfiles-0.5.0, arraydiff-0.5.0
collected 9 items

../../../romancal/romancal/ramp_fitting/tests/test_ramp_fit.py .........                                                                     [100%]

================================================================ 9 passed in 7.13s

The regression tests all pass,
https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/259/

@ddavis-stsci ddavis-stsci added this to the 23Q4_B11 milestone Jun 28, 2023
@ddavis-stsci ddavis-stsci self-assigned this Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5d28221) 75.70% compared to head (0ea0dd1) 75.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #725   +/-   ##
=======================================
  Coverage   75.70%   75.70%           
=======================================
  Files          90       90           
  Lines        5478     5478           
=======================================
  Hits         4147     4147           
  Misses       1331     1331           
Flag Coverage Δ *Carryforward flag
nightly 64.54% <ø> (ø) Carriedforward from 5d28221

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ddavis-stsci ddavis-stsci marked this pull request as ready for review June 28, 2023 14:41
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner June 28, 2023 14:41
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@ddavis-stsci ddavis-stsci merged commit 72c3785 into spacetelescope:main Jun 28, 2023
@ddavis-stsci
Copy link
Collaborator Author

Need to alter the tolerance to account for Linux/Mac precision differences?

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants