-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-604 update ramp fitting unit test for stcal 1.4.0 #725
Conversation
26c1ec0
to
d056336
Compare
for more information, see https://pre-commit.ci
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
=======================================
Coverage 75.70% 75.70%
=======================================
Files 90 90
Lines 5478 5478
=======================================
Hits 4147 4147
Misses 1331 1331
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me.
Need to alter the tolerance to account for Linux/Mac precision differences? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves RCAL-604
Closes #
This PR updates the ramp fitting unit tests for changes in stcal needed by JWST (JP-3242)
Checklist
CHANGES.rst
under the corresponding subsectionThe regression tests all pass,
https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/259/