Remove numpy 2.0 hack #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 94 94
Lines 5694 5690 -4
=======================================
- Hits 4382 4379 -3
+ Misses 1312 1311 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Regression tests (in devdeps mode) pass: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/299/ |
schlafly
approved these changes
Jul 28, 2023
WilliamJamieson
force-pushed
the
remove_hack
branch
2 times, most recently
from
c54c8bb to
d7147e5
Compare
This reverts commit aff40eb.
WilliamJamieson
force-pushed
the
remove_hack
branch
from
d7147e5 to
383b1c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #795 a temporary hack to side step an issue ASDF was experiencing relative to the new
numpy2.0 changes was introduced to facilitate continued testing. This issue was fixed with the merger of asdf-format/asdf#1605. Since this issue is currently only experienced by the devdeps tests, this hack can be reverted.Checklist
CHANGES.rstunder the corresponding subsection