Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-647 Update pipeline to include refpix step as default #890

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

ddavis-stsci
Copy link
Collaborator

@ddavis-stsci ddavis-stsci commented Sep 26, 2023

Resolves RCAL-647

Closes #883

This PR adds the refpix step to the standard pipeline processing. It also has the refpix step update the cal_step attribute and uses the standard suffix "refpix" instead of the fallback of "refpixstep".

Checklist

@ddavis-stsci ddavis-stsci added this to the 24Q1_B12 milestone Sep 26, 2023
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner September 26, 2023 14:15
@ddavis-stsci ddavis-stsci self-assigned this Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
romancal/pipeline/exposure_pipeline.py 40.74% <0.00%> (-0.39%) ⬇️
romancal/refpix/refpix_step.py 44.00% <0.00%> (-17.12%) ⬇️

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ddavis-stsci ddavis-stsci merged commit 786edf6 into spacetelescope:main Sep 26, 2023
@ddavis-stsci ddavis-stsci deleted the rcal-647 branch September 26, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update exposure_pipeline.py to include refpix
2 participants