Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add astropy Table support to compare_asdf #915

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Sep 29, 2023

tweakreg_catalog is now stored as an astropy.table.Table. This PR adds astropy.table.Table support to compare_asdf to allow regression tests to compare any Table instances (including tweakreg_catalog). This should fix tests that are failing with a reported difference that includes the unprocessed key (indicating that a portion of the items to being compared could not be processed due to lack of support for Table comparisons).

Regression tests all passed: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/393/

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@braingram braingram marked this pull request as ready for review September 29, 2023 17:55
@braingram braingram requested a review from a team as a code owner September 29, 2023 17:55
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
romancal/regtest/regtestdata.py 63.47% <100.00%> (+2.05%) ⬆️

📢 Thoughts on this report? Let us know!.

@ddavis-stsci ddavis-stsci added this to the 24Q1_B12 milestone Sep 29, 2023
Copy link
Collaborator

@mairanteodoro mairanteodoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Thanks, @braingram!

@braingram braingram merged commit 0cef2b2 into spacetelescope:main Sep 29, 2023
@braingram braingram deleted the table_diff branch September 29, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants