-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update url for webbpsf data in github actions CI #920
Conversation
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Is there some reason that this file is not in artifactory? It is only 69MB in size. Also if box is down (as it was last night) the tests will just fail? |
That's a good question. @zacharyburnett do the github CI runs have access to artifactory? At the moment yes if box is down the tests will fail as the romancal/.github/workflows/roman_ci.yml Line 81 in 92b07ff
I have been unable to find any documentation from the webbpsf project on when this file is updated. I believe the shared link for the data files included in this PR is intended to stay up-to-date based off the release docs for webbpsf which state:
|
Not currently, but when we transition to on-prem runners they |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL will work going forward, and the data located at this URL will be in sync with the latest release of WebbPSF, so I'm approving this PR.
There's a further improvement that we should make to this action thanks to recent updates to the WebbPSF required data infrastructure from @bsappington. We can now also access that file from central store without a remote download, at /grp/jwst/ote/webbpsf-data
, which may be preferable to avoid timeouts/relying on Box. I won't be back in-office until Oct 16 to make a PR to use central store rather than Box. If someone else wants to do it, you're welcome to 😄
CI failures are unrelated to these changes and are also occurring on main: |
This PR updates the url used for fetching webbpsf data to the most recent one in the webbpsf docs.
https://webbpsf.readthedocs.io/en/latest/installation.html#installing-the-required-data-files
Based off the comments and changes in spacetelescope/webbpsf#739
the shared url for the webbpsf data used in this PR should (hopefully) stay up-to-date for future webbpsf data releases.
Checklist
CHANGES.rst
under the corresponding subsection