Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update url for webbpsf data in github actions CI #920

Merged
merged 1 commit into from
Oct 4, 2023
Merged

update url for webbpsf data in github actions CI #920

merged 1 commit into from
Oct 4, 2023

Conversation

braingram
Copy link
Collaborator

This PR updates the url used for fetching webbpsf data to the most recent one in the webbpsf docs.
https://webbpsf.readthedocs.io/en/latest/installation.html#installing-the-required-data-files

Based off the comments and changes in spacetelescope/webbpsf#739
the shared url for the webbpsf data used in this PR should (hopefully) stay up-to-date for future webbpsf data releases.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@braingram braingram requested a review from a team as a code owner October 2, 2023 20:50
@braingram braingram requested a review from bmorris3 October 2, 2023 20:52
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@ddavis-stsci
Copy link
Collaborator

Is there some reason that this file is not in artifactory? It is only 69MB in size. Also if box is down (as it was last night) the tests will just fail?
Do we have instructions on how to update this file?

@braingram
Copy link
Collaborator Author

Is there some reason that this file is not in artifactory? It is only 69MB in size. Also if box is down (as it was last night) the tests will just fail? Do we have instructions on how to update this file?

That's a good question. @zacharyburnett do the github CI runs have access to artifactory?

At the moment yes if box is down the tests will fail as the data job (which fails if the file on box fails to download) is a prerequisite of many of the other CI jobs (including all that run the unit tests):

romancal/.github/workflows/roman_ci.yml

Line 81 in 92b07ff

needs: [ data ]

I have been unable to find any documentation from the webbpsf project on when this file is updated. I believe the shared link for the data files included in this PR is intended to stay up-to-date based off the release docs for webbpsf which state:

Verify the shared link of webbpsf-data-latest.tar.gz is the same that exists in docs/installation.rst (“copy shared link” then “link settings”)

@zacharyburnett
Copy link
Collaborator

zacharyburnett commented Oct 3, 2023 •
edited
Loading

@zacharyburnett do the github CI runs have access to artifactory?

Not currently, but when we transition to on-prem runners they will should.

bmorris3
bmorris3 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL will work going forward, and the data located at this URL will be in sync with the latest release of WebbPSF, so I'm approving this PR.

There's a further improvement that we should make to this action thanks to recent updates to the WebbPSF required data infrastructure from @bsappington. We can now also access that file from central store without a remote download, at /grp/jwst/ote/webbpsf-data, which may be preferable to avoid timeouts/relying on Box. I won't be back in-office until Oct 16 to make a PR to use central store rather than Box. If someone else wants to do it, you're welcome to 😄

@braingram
Copy link
Collaborator Author

Thanks @bmorris3
#918 updates romancal jenkins jobs to use the data from /grp.

@braingram
Copy link
Collaborator Author

CI failures are unrelated to these changes and are also occurring on main:
https://github.com/spacetelescope/romancal/actions/runs/6394475030/job/17355965466#step:10:201

@braingram braingram mentioned this pull request Oct 3, 2023
Merged
6 tasks
@zacharyburnett zacharyburnett merged commit cd8cdb1 into spacetelescope:main Oct 4, 2023
@zacharyburnett zacharyburnett deleted the webbpsf_url branch October 4, 2023 17:55
mairanteodoro pushed a commit to mairanteodoro/romancal that referenced this pull request Oct 5, 2023
@braingram @mairanteodoro
update url for webbpsf data in github actions CI (spacetelescope#920)
e8b139e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorris3 bmorris3 bmorris3 approved these changes

@zacharyburnett zacharyburnett zacharyburnett approved these changes

Assignees
No one assigned
Labels
automation no-changelog-entry-needed testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@braingram @ddavis-stsci @zacharyburnett @bmorris3