use ndarray comparison options in wcs comparison #941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing 2 WCS objects in the deepdiff computed between the regtest result and truth file, use the array comparison options that are used for other arrays in the diff.
These changes will mean that if both the result and truth WCS objects return
nan
when evaluated on the bounding box (this is what's used to compare the two objects) that the WCS objects can be considered equal if both WCS objects return the samenan
s.Checklist
CHANGES.rst
under the corresponding subsectionRunning regression tests at: https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%252FRoman-Developers-Pull-Requests/detail/Roman-Developers-Pull-Requests/426/