Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retrieve CRDS contexts in CI with a reusable workflow #954

Merged
merged 3 commits into from
Oct 30, 2023
Merged

retrieve CRDS contexts in CI with a reusable workflow #954

merged 3 commits into from
Oct 30, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Oct 25, 2023 •
edited
Loading

This PR simplifies the data caching step by outsourcing the CRDS context retrieval to the reusable workflow from the CRDS repository. Also, renamed jobs to make them more explicit on what they do, and removed redundant check/build-dist check

before
image

after
image

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@zacharyburnett zacharyburnett self-assigned this Oct 25, 2023
@zacharyburnett zacharyburnett force-pushed the ci/improve_data_caching branch from 6445255 to 4f67af5 Compare October 25, 2023 16:59
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

zacharyburnett
zacharyburnett commented Oct 25, 2023
View reviewed changes
@zacharyburnett zacharyburnett marked this pull request as ready for review October 25, 2023 17:40
@zacharyburnett zacharyburnett requested a review from a team as a code owner October 25, 2023 17:40
@zacharyburnett zacharyburnett changed the title use reusable workflow from CRDS retrieve CRDS contexts in CI with a reusable workflow Oct 25, 2023
@zacharyburnett zacharyburnett force-pushed the ci/improve_data_caching branch from c8e16a2 to 401dda7 Compare October 27, 2023 17:48
schlafly
schlafly approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, you are the expert here!

@zacharyburnett zacharyburnett merged commit 5dd0ce8 into spacetelescope:main Oct 30, 2023
@zacharyburnett zacharyburnett deleted the ci/improve_data_caching branch October 30, 2023 13:54
ddavis-stsci pushed a commit to ddavis-stsci/romancal that referenced this pull request Nov 7, 2023
@zacharyburnett @ddavis-stsci
retrieve CRDS contexts in CI with a reusable workflow (spacetelescope…
c53037d 
…#954)
@braingram
Copy link
Collaborator

@bmorris3 @zacharyburnett I think these are the changes that need adapted to devdeps to fix the failing tests on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlafly schlafly schlafly approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
automation no-changelog-entry-needed testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zacharyburnett @braingram @schlafly