Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crds rad and roman_datamodels versions #986

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Update crds rad and roman_datamodels versions #986

merged 1 commit into from
Nov 10, 2023

Conversation

ddavis-stsci
Copy link
Collaborator

Resolves RCAL-nnnn

Closes #

This PR updates the versions of rad and roman_datamodels to match INS ref files and CRDS pmap to roman_0052

Checklist

  • [N/A] added entry in CHANGES.rst under the corresponding subsection
  • [N/A] updated relevant tests
  • [N/A] updated relevant documentation
  • [N/A] updated relevant milestone(s)
  • [N/A] added relevant label(s)
  • [N/A] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@ddavis-stsci ddavis-stsci added this to the 24Q1_B12 milestone Nov 10, 2023
@ddavis-stsci ddavis-stsci self-assigned this Nov 10, 2023
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner November 10, 2023 16:25
@github-actions github-actions bot added dependencies Pull requests that update a dependency file regression_testing automation labels Nov 10, 2023
schlafly
schlafly approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@ddavis-stsci ddavis-stsci merged commit e62468b into spacetelescope:main Nov 10, 2023
@ddavis-stsci ddavis-stsci deleted the Updatecrds branch November 10, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlafly schlafly schlafly approved these changes

Assignees

@ddavis-stsci ddavis-stsci

Labels
24Q1_B12 automation dependencies Pull requests that update a dependency file no-changelog-entry-needed regression_testing
Projects
None yet
Milestone
24Q1_B12
Development

Successfully merging this pull request may close these issues.
2 participants
@ddavis-stsci @schlafly