Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue where the path of the WebbPSF cache was not the same as the restore cache in the subsequent workflow #988

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix issue where the path of the WebbPSF cache was not the same as the restore cache in the subsequent workflow #988

merged 1 commit into from
Nov 13, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Nov 13, 2023 •
edited
Loading

This PR addresses an issue where the cached WebbPSF data was not actually restored:
https://github.com/spacetelescope/romancal/actions/runs/6829635768/job/18623576605?pr=980#step:3:10

This was because the paths were different; GitHub Actions caches must have the same key AND path to match an actions/cache call

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@zacharyburnett zacharyburnett self-assigned this Nov 13, 2023
@zacharyburnett zacharyburnett requested a review from a team as a code owner November 13, 2023 14:27
schlafly
schlafly approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

zacharyburnett
zacharyburnett commented Nov 13, 2023
View reviewed changes
.github/workflows/data.yml
path: ${{ needs.webbpsf_path.outputs.path }}
path: ${{ needs.path.outputs.path }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the offending line, for future reference (and other repos' workflows that may have the same problem)

bmorris3
bmorris3 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you thank you!

@zacharyburnett zacharyburnett merged commit 6c2f933 into spacetelescope:main Nov 13, 2023
@zacharyburnett zacharyburnett deleted the ci/fix_webbpsf branch November 13, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlafly schlafly schlafly approved these changes

@bmorris3 bmorris3 bmorris3 approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
automation no-changelog-entry-needed update webbpsf data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zacharyburnett @schlafly @bmorris3