Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix webbpsf data download cache #203

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Feb 14, 2025

Similar to spacetelescope/romancal#1619

This won't work until:

This is a stop-gap fix until this package can be migrated to stpsf.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.36%. Comparing base (244858c) to head (43d030a).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   90.02%   80.36%   -9.66%     
==========================================
  Files          17       17              
  Lines        2165     2175      +10     
==========================================
- Hits         1949     1748     -201     
- Misses        216      427     +211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review February 14, 2025 16:05
@braingram braingram requested a review from a team as a code owner February 14, 2025 16:05
@schlafly schlafly merged commit bc586c7 into spacetelescope:main Feb 14, 2025
12 of 19 checks passed
@braingram braingram deleted the fix_cache branch February 14, 2025 16:14
@braingram
Copy link
Contributor Author

Thanks! I don't have permissions to trigger the workflow at:
https://github.com/spacetelescope/romanisim/actions/workflows/data.yml
There should be a button to "Run workflow" (all defaults are fine)
Screenshot 2025-02-14 at 11 42 55 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants