Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One last webbpsf/stpsf change, cleanup warnings, remove unused file #206

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Feb 18, 2025

This PR:

I attempted to turn warnings into errors but a few tests failed with resource warnings (due to open files):
https://github.com/spacetelescope/romanisim/actions/runs/13392587089/job/37403626586?pr=206
So I removed that filter change.

With this PR the unit tests now run without webbpsf/stpsf data warnings:
https://github.com/spacetelescope/romanisim/actions/runs/13393139977/job/37405428093?pr=206#step:10:205

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (244858c) to head (188d6a2).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   90.02%   89.85%   -0.18%     
==========================================
  Files          17       17              
  Lines        2165     2178      +13     
==========================================
+ Hits         1949     1957       +8     
- Misses        216      221       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram changed the title Stpsf env One last webbpsf/stpsf change, cleanup warnings, remove unused file Feb 18, 2025
@braingram braingram marked this pull request as ready for review February 18, 2025 14:48
@braingram braingram requested a review from a team as a code owner February 18, 2025 14:48
@braingram braingram requested a review from schlafly February 18, 2025 14:49
@schlafly
Copy link
Collaborator

Ugh, sorry---thank you!

@schlafly schlafly merged commit 7237359 into spacetelescope:main Feb 18, 2025
20 of 21 checks passed
@braingram braingram deleted the stpsf_env branch February 18, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants