Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common code for linearity correction #55

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

cshanahan1
Copy link
Collaborator

Adds common code for linearity correction (WIP)

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #55 (2d72add) into main (6b9ddd3) will increase coverage by 2.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   19.91%   21.99%   +2.08%     
==========================================
  Files          13       14       +1     
  Lines        1572     1614      +42     
==========================================
+ Hits          313      355      +42     
  Misses       1259     1259              
Impacted Files Coverage Δ
src/stcal/linearity/linearity.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9ddd3...2d72add. Read the comment docs.

@nden nden requested a review from dmggh October 7, 2021 20:11
Copy link
Contributor

@dmggh dmggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for residual print statement.

src/stcal/linearity/linearity_correction.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kmacdonald-stsci kmacdonald-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are codecov comments saying the code isn't covered by tests. Is this code covered by the JWST tests or will those tests be moved to STCAL?

CHANGES.rst Outdated Show resolved Hide resolved
src/stcal/linearity/linearity.py Outdated Show resolved Hide resolved
src/stcal/linearity/linearity.py Outdated Show resolved Hide resolved
src/stcal/linearity/linearity.py Outdated Show resolved Hide resolved
src/stcal/linearity/linearity.py Outdated Show resolved Hide resolved
src/stcal/linearity/linearity.py Outdated Show resolved Hide resolved
@nden
Copy link
Collaborator

nden commented Oct 12, 2021

The error in the jwst tests is understood and fixed in other PRs, awaiting release of stcal.
Merging this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants