-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common code for linearity correction #55
Conversation
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 19.91% 21.99% +2.08%
==========================================
Files 13 14 +1
Lines 1572 1614 +42
==========================================
+ Hits 313 355 +42
Misses 1259 1259
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for residual print statement.
c161cf3
to
f660d1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are codecov comments saying the code isn't covered by tests. Is this code covered by the JWST tests or will those tests be moved to STCAL?
f660d1b
to
c88f093
Compare
The error in the jwst tests is understood and fixed in other PRs, awaiting release of stcal. |
Adds common code for linearity correction (WIP)