JP-2297: Properly handle DO_NOT_USE DQ flag for multi-integration processing #60
Conversation
…tils.dq_comopress_final function.
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 94.48% 94.51% +0.03%
==========================================
Files 14 14
Lines 1614 1624 +10
==========================================
+ Hits 1525 1535 +10
Misses 89 89
Continue to review full report at Codecov.
|
hbushouse
changed the title
tests/test_ramp_fitting.py
Outdated
| # ----------------------------------------------------------------------------- | ||
| # Set up functions | ||
|
|
||
| # Need test for multi-ints near zero with positive and negative slopes |
There was a problem hiding this comment.
"Near zero" ? I don't quite follow.
There was a problem hiding this comment.
This was an old comment I didn't see was still there. I removed this because it doesn't apply here and is confusing.
|
|
||
| def test_utils_dq_compress_final(): | ||
| """ | ||
| Set up a multi-integration 3 pixel data array each ramp as the following: |
There was a problem hiding this comment.
I don't follow what is being tested here - can you add some clarification ?
There was a problem hiding this comment.
I am expanding the comment for this test. Let me know if I need to expand it further.
… test to make it more understandable.
) * Initial changes, with tests, to zero out Poisson variances for pixels with negative median rates. * Modifying test file structure. * Adding comment. * Making style changes. * Moving ramp fitting unit tests to the top level 'tests' directory. * Changed test comments and change log based on code review feedback. * Making changes to the change log.
|
@kmacdonald-stsci Please rebase to resolve the conflict. |
|
Also there's a flake 8 issue |
…tils.dq_comopress_final function. Adding a test for the new dq_compress_final function. Changing a line to make it clearer a uint32 is required for the computation. Changing style failures in ramp fitting test file. Adding to the change log. Removing a confusing comment and expanding the comment explaining the test to make it more understandable. Correcting style fails.
CHANGES.rst
Outdated
| @@ -4,6 +4,7 @@ | |||
| ramp_fitting | |||
| ------------ | |||
|
|
|||
| - For slopes with negative median rates, the Poisson variance is zero. [#33] | |||
| - Changed the way the final DQ array gets computed when handling the DO_NOT_USE | |||
| flag for multi-integration data. | |||
There was a problem hiding this comment.
Does the parser need to have the continuation line intended to the same level as the start of the text in the preceding line? (i.e. this may need to be intended 2 spaces)
CHANGES.rst
Outdated
|
|
||
| - For slopes with negative median rates, the Poisson variance is zero. [#33] | ||
| - Changed the way the final DQ array gets computed when handling the DO_NOT_USE | ||
| flag for multi-integration data. |
There was a problem hiding this comment.
This one is missing the PR number.
There was a problem hiding this comment.
Also the previous PR number is incorrect. It is #59
There was a problem hiding this comment.
Ah. I put issue number, not PR number. I'm changing this now.
|
Thanks @kmacdonald-stsci |
It is possible during ramp fitting for a pixel to be marked as
DO_NOT_USEdue to saturation in one integration, but not another. For pixels good data in one or more integrations having unusable date in other integrations, the final DQ flag should not be marked asDO_NOT_USE.Fixes spacetelescope/jwst#6379
Resolves JP-2297