Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2071: Add feature to turn off calculations for saturated ramps with good 0th group #76

Merged
merged 6 commits into from
Mar 2, 2022

Conversation

kmacdonald-stsci
Copy link
Collaborator

Resolves JP-2071

A suppress_one_group boolean variable has been added as a parameter to the ramp_fit function.

When true saturated ramps with only the 0th group being good will be treated as completely saturated ramps. The calculations will be done as if all calculations are saturated, but the DQ flags will be set as if the first group is good, i.e., the pixel DQ will not have DO_NOT_USE set.

When false saturated ramps with only the 0th group being good will be treated as the normal special case of having only one good group.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #76 (9b4904f) into main (47aec18) will increase coverage by 0.09%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   88.63%   88.73%   +0.09%     
==========================================
  Files          16       16              
  Lines        2262     2290      +28     
==========================================
+ Hits         2005     2032      +27     
- Misses        257      258       +1     
Impacted Files Coverage Δ
src/stcal/ramp_fitting/gls_fit.py 63.36% <ø> (ø)
src/stcal/ramp_fitting/ramp_fit.py 95.00% <96.55%> (+0.88%) ⬆️
src/stcal/ramp_fitting/ols_fit.py 93.77% <100.00%> (ø)
src/stcal/ramp_fitting/ramp_fit_class.py 100.00% <100.00%> (ø)
src/stcal/ramp_fitting/utils.py 98.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47aec18...9b4904f. Read the comment docs.

src/stcal/ramp_fitting/ramp_fit.py Show resolved Hide resolved
src/stcal/ramp_fitting/ramp_fit.py Outdated Show resolved Hide resolved
src/stcal/ramp_fitting/ramp_fit.py Show resolved Hide resolved
src/stcal/ramp_fitting/utils.py Outdated Show resolved Hide resolved
tests/test_ramp_fitting.py Show resolved Hide resolved
tests/test_ramp_fitting.py Show resolved Hide resolved
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse
Copy link
Collaborator

We need reviews and approvals from either @dmggh or @nden

Copy link
Contributor

@dmggh dmggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kmacdonald-stsci kmacdonald-stsci merged commit 7683909 into spacetelescope:main Mar 2, 2022
@kmacdonald-stsci kmacdonald-stsci deleted the jp_2071_sat branch March 2, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants