-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2071: Add feature to turn off calculations for saturated ramps with good 0th group #76
JP-2071: Add feature to turn off calculations for saturated ramps with good 0th group #76
Conversation
… all other groups are saturated.
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 88.63% 88.73% +0.09%
==========================================
Files 16 16
Lines 2262 2290 +28
==========================================
+ Hits 2005 2032 +27
- Misses 257 258 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Resolves JP-2071
A
suppress_one_group
boolean variable has been added as a parameter to theramp_fit
function.When true saturated ramps with only the 0th group being good will be treated as completely saturated ramps. The calculations will be done as if all calculations are saturated, but the DQ flags will be set as if the first group is good, i.e., the pixel DQ will not have DO_NOT_USE set.
When false saturated ramps with only the 0th group being good will be treated as the normal special case of having only one good group.