Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2572: Updating the handler for the suppression of one good group ramps. #92

Merged
merged 3 commits into from
May 20, 2022

Conversation

kmacdonald-stsci
Copy link
Collaborator

Due to the possibility the first groups of a ramp could be flagged as DO_NOT_USE, as well as the way the jump detector works, the one good group suppression handler needed to be modified to handle these cases as well.

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #92 (a1456a1) into main (aa8c814) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   90.13%   90.15%   +0.02%     
==========================================
  Files          16       16              
  Lines        2433     2438       +5     
==========================================
+ Hits         2193     2198       +5     
  Misses        240      240              
Impacted Files Coverage Δ
src/stcal/ramp_fitting/ramp_fit.py 96.84% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8c814...a1456a1. Read the comment docs.

Copy link
Collaborator

@mwregan2 mwregan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@dmggh dmggh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from 2 minor comments, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants