-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2572: Updating the handler for the suppression of one good group ramps. #92
Conversation
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 90.13% 90.15% +0.02%
==========================================
Files 16 16
Lines 2433 2438 +5
==========================================
+ Hits 2193 2198 +5
Misses 240 240
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from 2 minor comments, looks good.
Due to the possibility the first groups of a ramp could be flagged as DO_NOT_USE, as well as the way the jump detector works, the one good group suppression handler needed to be modified to handle these cases as well.