JP-3796: Store slit scales in slit datamodel #379
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves JP-3796
Partially resolves JP-1341
Adding a couple metadata values relevant to NIRSpec MOS data to the slit and spec datamodels.
The slit_xscale and slit_yscale attributes will hold the scale factor to convert from slit coordinates relative to the open MSA shutter area (DMS style) to coordinates relative to the full shutter pitch (PPS style). These values will be derived from data in one of the NIRSpec WCS reference files (the MSA file), and are necessary to convert DMS-style slit coordinates, such as source_xpos and source_ypos, to sky coordinates (JP-1341). Barshadow corrections also require an accurate slit_yscale value to scale correctly to large slits like NIRSpec MOS data in longslit mode (JP-3796).
The scale values are different for each MSA quadrant, so it would be helpful for users to also store the quadrant value for the slit. The quadrant is already defined in the slit datamodel (without a FITS keyword) but is not defined at all in the spectral datamodel. I added it to the spectral datamodel and added a FITS keyword for both.
Proposed new FITS keywords for SCI extensions in SlitModel or MultiSlitModel data or EXTRACT1D extensions in MultiSpecModel data are: MSAQUAD, SLTXSCL, SLTYSCL. They should be populated only for NIRSpec MOS data, and should not need to be searchable in the archive.
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)jwst
regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>"
)news fragment change types...
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.misc.rst
: infrastructure or miscellaneous change