Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miri lrs spec wcs model #393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jemorrison
Copy link
Contributor

@jemorrison jemorrison commented Feb 3, 2025

Helps Resolve JP-3848

This PR replaces #382. There we too many conflicts to resolve easily after the code style changes were made.

Closes #

This PR adds a datamodel of the reference file, specwcs, for MIRI LRS data. It can be used for fixed slit or slitless data. The reference file for fixed slit contains the V2,V3 corners of the slit. These values are not in the slitless reference file and default to None when the reference files are read in using the data models

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@jemorrison jemorrison requested a review from a team as a code owner February 3, 2025 22:34
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 53.19149% with 22 lines in your changes missing coverage. Please review.

Project coverage is 77.94%. Comparing base (788f7bd) to head (33a6407).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/stdatamodels/jwst/datamodels/wcs_ref_models.py 53.19% 22 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #393       +/-   ##
===========================================
+ Coverage   67.59%   77.94%   +10.34%     
===========================================
  Files         115      115               
  Lines        5932     5192      -740     
===========================================
+ Hits         4010     4047       +37     
+ Misses       1922     1145      -777     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jemorrison jemorrison mentioned this pull request Feb 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant