Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use numpy.nanmean by default #3

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

zacharyburnett
Copy link
Collaborator

as described in spacetelescope/romancal#953 (comment), using numpy.nanmean addresses the case where frames may have NaN

@zacharyburnett zacharyburnett self-assigned this Nov 3, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review November 3, 2023 18:38
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/stpreview/downsample.py 97.05% <ø> (+70.58%) ⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@zacharyburnett zacharyburnett merged commit 4b69438 into spacetelescope:main Nov 3, 2023
@zacharyburnett zacharyburnett deleted the bug/nanmean branch November 3, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant