Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add manylinux2014 recipe #58

Closed
wants to merge 2 commits into from
Closed

Conversation

eugeneswalker
Copy link
Collaborator

Here is the updated manylinux2014 centos7 recipe with stipped out libcrypt.so per advice from @haampie

Retry of prior PR following #57 (comment)

@eugeneswalker
Copy link
Collaborator Author

Failing check here Build pcluster-amazonlinux-2 seems unrelated to this PR.

@eugeneswalker eugeneswalker requested a review from alalazo December 3, 2024 18:10
@eugeneswalker eugeneswalker enabled auto-merge (squash) December 9, 2024 16:28
@eugeneswalker
Copy link
Collaborator Author

CI here failing for reasons unrelated to this PR. Otherwise this is ready to merge

@haampie
Copy link
Member

haampie commented Dec 10, 2024

I wouldn't call this manylinux, that's a python invention for centos with various pythons installed.

Many just centos 7 or linux-glibc2.17?

Also it would be good to install an optimized python and prebuilt clingo binaries, otherwise every build job downloads clingo.

For example clingo-bootstrap@spack +optimized ^[email protected] +optimizations like in https://github.com/spack/gitlab-runners/blob/main/spack.yaml

@eugeneswalker
Copy link
Collaborator Author

Many just centos 7 or linux-glibc2.17?

Yes, I like this better

Also it would be good to install an optimized python and prebuilt clingo binaries, otherwise every build job downloads clingo.

For example clingo-bootstrap@spack +optimized ^[email protected] +optimizations like in https://github.com/spack/gitlab-runners/blob/main/spack.yaml

Good idea. I will update the recipe with this

@haampie
Copy link
Member

haampie commented Dec 16, 2024

Closing this in favor of #59

@haampie haampie closed this Dec 16, 2024
auto-merge was automatically disabled December 16, 2024 09:47

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants