Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compadre and py-pycompadre to v1.6.0 #47948

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Update compadre and py-pycompadre to v1.6.0 #47948

merged 2 commits into from
Dec 10, 2024

Conversation

kuberry
Copy link
Contributor

@kuberry kuberry commented Dec 5, 2024 •
edited
Loading

  • Adds release 1.6.0 to compadre and py-pycompadre
  • Changes made to make the two packages more uniform in their requirements
  • Removed trilinos variant from py-pycompadre as Kokkos and Kokkos-Kernels are now external to [email protected]:

@kuberry kuberry requested a review from eugeneswalker December 9, 2024 22:14
eugeneswalker
eugeneswalker previously approved these changes Dec 9, 2024
View reviewed changes
@eugeneswalker
Copy link
Contributor

Ready to merge?

tldahlgren
tldahlgren requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some inconsistencies in the dependencies and the requirements listed in the versions' setup.py files.

var/spack/repos/builtin/packages/py-pycompadre/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-pycompadre/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-pycompadre/package.py Outdated Show resolved Hide resolved
@kuberry kuberry force-pushed the update_compadre_v1.6.0 branch from a8f0420 to a78ba25 Compare December 10, 2024 02:53
@tldahlgren tldahlgren merged commit cb8880b into spack:develop Dec 10, 2024
15 checks passed
@kuberry kuberry deleted the update_compadre_v1.6.0 branch December 11, 2024 15:40
fryeguy52 pushed a commit to fryeguy52/spack that referenced this pull request Dec 17, 2024
@kuberry @fryeguy52
Update compadre and py-pycompadre to v1.6.0 (spack#47948)
df1fa2d 
* compadre: add version 1.6.0
* py-pycompadre: add version 1.6.0
tdrwenski pushed a commit to tdrwenski/spack that referenced this pull request Dec 26, 2024
@kuberry @tdrwenski
Update compadre and py-pycompadre to v1.6.0 (spack#47948)
e01c593 
* compadre: add version 1.6.0
* py-pycompadre: add version 1.6.0
kshea21 pushed a commit to kshea21/spack that referenced this pull request Dec 26, 2024
@kuberry @kshea21
Update compadre and py-pycompadre to v1.6.0 (spack#47948)
1be2477 
* compadre: add version 1.6.0
* py-pycompadre: add version 1.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tldahlgren tldahlgren tldahlgren approved these changes

@eugeneswalker eugeneswalker eugeneswalker left review comments

Assignees

@tldahlgren tldahlgren

@eugeneswalker eugeneswalker

Labels
dependencies new-variant new-version patch python update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuberry @eugeneswalker @tldahlgren