Clean up APIServer #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdaniel
approved these changes
Jan 18, 2021
GregMefford
force-pushed
the
cleanup_api_server
branch
from
a961af2 to
aa1616a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out
enqueue_tracemaybe_flush_tracessteps from the:send_tracehandler.Basically no change in behavior except that now we consistently write a log (when
verbose?: true) that a trace has been added to the stack at the time that the batch size is reached and the stack is flushed to the Datadog Agent.While reviewing #28, I noticed that we were missing an obvious place to add telemetry about what the APIServer is doing internally, so I split this out in preparation for adding telemetry about these distinct steps happening.